linux-kernel - Re: [PATCH v2 -mm 9/9] netconsole: Support dynamic reconfiguration using configfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 Jul 2007 22:38:17 +0530 (IST)
From:	Satyam Sharma <ssatyam@....iitk.ac.in>
To:	Keiichi KII <k-keiichi@...jp.nec.com>
cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Matt Mackall <mpm@...enic.com>,
	Netdev <netdev@...r.kernel.org>,
	Joel Becker <joel.becker@...cle.com>,
	Stephen Hemminger <shemminger@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH v2 -mm 9/9] netconsole: Support dynamic reconfiguration
 using configfs

Hi,

On Thu, 12 Jul 2007, Keiichi KII wrote:
> Hi Satyam,
> 
> >  struct netconsole_target {
> >  	struct list_head	list;
> > +#ifdef	CONFIG_NETCONSOLE_DYNAMIC
> > +	struct config_item	item;
> > +	int			enabled;
> > +#endif
> >  	struct netpoll		np;
> >  };
> 
> If CONFIG_NETCONSOLE_DYNAMIC is unset, we can't access to the "enabled" member.
> So, the compile errors occur because the following functions make use of 
> the above one.

Gargh, yes.

> Signed-off-by: Keiichi Kii <k-keiichi@...jp.nec.com>
> 
> Index: mm/drivers/net/netconsole.c
> ===================================================================
> --- mm.orig/drivers/net/netconsole.c
> +++ mm/drivers/net/netconsole.c
> @@ -94,8 +94,8 @@ struct netconsole_target {
>         struct list_head        list;
>  #ifdef CONFIG_NETCONSOLE_DYNAMIC
>         struct config_item      item;
> -       int                     enabled;
>  #endif
> +       int                     enabled;
>         struct netpoll          np;
>  };

Yup, enabled should be out of CONFIG_NETCONSOLE_DYNAMIC. I'll include this
change in the next version as well.

Thanks,
Satyam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/