linux-kernel - Re: [PATCH] rocket: Fix mutex locking compile warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070711182721.0c0e2235.akpm@linux-foundation.org>
Date:	Wed, 11 Jul 2007 18:27:21 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Michael Buesch <mb@...sch.de>
Cc:	tytso@....edu, "linux-kernel" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rocket: Fix mutex locking compile warning

On Thu, 12 Jul 2007 01:56:32 +0200
Michael Buesch <mb@...sch.de> wrote:

> This fixes
> 
> drivers/char/rocket.c: In function ‘rp_write’:
> drivers/char/rocket.c:1705: warning: ignoring return value of ‘mutex_lock_interruptible’, declared with attribute warn_unused_result
> 
> Signed-off-by: Michael Buesch <mb@...sch.de>
> 
> Index: bu3sch-wireless-dev/drivers/char/rocket.c
> ===================================================================
> --- bu3sch-wireless-dev.orig/drivers/char/rocket.c	2007-05-18 18:09:48.000000000 +0200
> +++ bu3sch-wireless-dev/drivers/char/rocket.c	2007-07-12 01:52:44.000000000 +0200
> @@ -1702,7 +1702,8 @@ static int rp_write(struct tty_struct *t
>  	if (count <= 0 || rocket_paranoia_check(info, "rp_write"))
>  		return 0;
>  
> -	mutex_lock_interruptible(&info->write_mtx);
> +	if (mutex_lock_interruptible(&info->write_mtx))
> +		return -ERESTARTSYS;
>  
>  #ifdef ROCKET_DEBUG_WRITE
>  	printk(KERN_INFO "rp_write %d chars...", count);
> 

Thanks, I already have this queued as
rocketc-fix-unchecked-mutex_lock_interruptible.patch
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/