linux-kernel - Re: [PATCH 013 of 20] knfsd: nfsd: factor out code from show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 13 Jul 2007 00:29:33 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	NeilBrown <neilb@...e.de>
Cc:	nfs@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	"J. Bruce Fields" <bfields@...i.umich.edu>
Subject: Re: [PATCH 013 of 20] knfsd: nfsd: factor out code from
 show_expflags

On Tue, 10 Jul 2007 12:27:37 +1000 NeilBrown <neilb@...e.de> wrote:

> +static void exp_flags(struct seq_file *m, int flag, int fsid,
> +		uid_t anonu, uid_t anong, struct nfsd4_fs_locations *fsloc)
> +{
> +	show_expflags(m, flag, NFSEXP_ALLFLAGS);
>  	if (flag & NFSEXP_FSID)
> -		seq_printf(m, "%sfsid=%d", first++?",":"", fsid);
> +		seq_printf(m, ",fsid=%d", fsid);
>  	if (anonu != (uid_t)-2 && anonu != (0x10000-2))
> -		seq_printf(m, "%sanonuid=%d", first++?",":"", anonu);
> +		seq_printf(m, ",sanonuid=%d", anonu);

It's a bit presumptuous to print a uid_t with "%d".  Fortunately it
will work OK with all the present architectures.

But in general: be cautious when feeding opaque types to printk.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/