linux-kernel - Re: [PATCH] Add nid sanity on alloc_pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070713012906.a6f63c90.pj@sgi.com>
Date:	Fri, 13 Jul 2007 01:29:06 -0700
From:	Paul Jackson <pj@....com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	joe.jin@...cle.com, bill.irwin@...cle.com,
	linux-kernel@...r.kernel.org, gurudas.pai@...cle.com,
	Zwane Mwaikambo <zwane@....linux.org.uk>
Subject: Re: [PATCH] Add nid sanity on alloc_pages_node

> I'm scratching my head over that min_t in __first_node(), too.   I don't think
> it's possible for find_first_bit(..., N) to return anything >N _anyway_.  And if
> it does, we want to know about it.
> 
> <looks at Paul>

I'm not sure I've got this right, but looks like that min_t went in after
Zwane Mwaikambo, then <zwane@...labs.com>, whom I am presuming is the same
person as now at <zwane@....linux.org.uk>, found a problem with the i386
find_next_bit implementation returning > N when merging i386 cpu hotplug.

See the thread:

  http://lkml.org/lkml/2004/7/31/102
  [PATCH][2.6] first/next_cpu returns values > NR_CPUS

I apparently lobbied at the time to mandate that find_first_bit(..., N)
return exactly N on failure to find a set bit, but gave up, after some
confusions on my part.

Adding Zwane to this thread -- the other participant on that thread,
Bill Irwin, is already on the CC list.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@....com> 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/