lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1184320602.2785.18.camel@shinybook.infradead.org>
Date:	Fri, 13 Jul 2007 10:56:42 +0100
From:	David Woodhouse <dwmw2@...radead.org>
To:	WANG Cong <xiyou.wangcong@...il.com>
Cc:	Josh Boyer <jwboyer@...ux.vnet.ibm.com>, kirk@....ee.ntu.edu.tw,
	akpm@...l.org, linux-mtd@...ts.infradead.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [Resend][Patch] drivers/mtd/maps/tqm8xxl.c: Do some cleanups

On Fri, 2007-07-13 at 11:48 +0800, WANG Cong wrote:
>                 if(map_banks[idx] == NULL) {
>                         ret = -ENOMEM;
> -                       /* FIXME: What if some MTD devices were probed already? */
> +                       /* FIXME: What if some MTD devices were probed
> +                       already? */
>                         goto error_mem;
>                 } 


That's just horrid. Leave it as it was.

-- 
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ