linux-kernel - Re: On current git head webservers stopped working

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.0.999.0707131025550.20061@woody.linux-foundation.org>
Date:	Fri, 13 Jul 2007 10:27:38 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Jens Axboe <jens.axboe@...cle.com>
cc:	Gabriel C <nix.or.die@...glemail.com>,
	linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: On current git head webservers stopped working



On Fri, 13 Jul 2007, Jens Axboe wrote:
> 
> Does this work?

Ok, so it apparently works, but:

> diff --git a/fs/splice.c b/fs/splice.c
> index ed2ce99..92646aa 100644
> --- a/fs/splice.c
> +++ b/fs/splice.c
> @@ -491,7 +491,7 @@ ssize_t generic_file_splice_read(struct file *in, loff_t *ppos,
>  
>  	ret = 0;
>  	spliced = 0;
> -	while (len) {
> +	while (len && !spliced) {
>  		ret = __generic_file_splice_read(in, ppos, pipe, len, flags);

This hunk basically make sthe whole "while" loop pointless. You'll never 
go through it more than once.

So at that point, maybe the loop should be removed entirely? Or maybe this 
part of the patch is wrong, and the fix was in the _other_ parts?

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/