[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20070714020713.36f604d2.akpm@linux-foundation.org>
Date: Sat, 14 Jul 2007 02:07:13 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Robert Hancock <hancockr@...w.ca>
Cc: linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
john stultz <johnstul@...ibm.com>
Subject: Re: 2.6.22-rc6-mm1
On Sat, 14 Jul 2007 01:22:10 -0600 Robert Hancock <hancockr@...w.ca> wrote:
> Andrew Morton wrote:
> > +x86_64-dynticks-disable-hpet_id_legsup-hpets.patch
> >
> > pretend to fix it
>
> I'm not sure what this patch does on x86_64, but it seems like it
> trashes all HPET support on i386?
>
It might do, if your i386 is old and has the HPET_ID_LEGSUP bit set.
The code path which that patch disables:
--- a/arch/i386/kernel/hpet.c~x86_64-dynticks-disable-hpet_id_legsup-hpets
+++ a/arch/i386/kernel/hpet.c
@@ -376,7 +376,7 @@ int __init hpet_enable(void)
clocksource_register(&clocksource_hpet);
- if (id & HPET_ID_LEGSUP) {
+ if (0 && (id & HPET_ID_LEGSUP)) {
hpet_enable_int();
hpet_reserve_platform_timers(id);
/*
_
will, if executed (on x86_64, at least), instaoops the machine. It might
take down i386 as well, dunno.
I'd forgotten about this problem, and it seems that Thomas & John have too.
It's a showstopper.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists