lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 14 Jul 2007 17:26:19 +0100 From: Christoph Hellwig <hch@...radead.org> To: Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca> Cc: akpm@...ux-foundation.org, linux-kernel@...r.kernel.org, prasanna@...ibm.com, ananth@...ibm.com, anil.s.keshavamurthy@...el.com, davem@...emloft.net Subject: Re: [patch 5/8] Immediate Values - kprobe header fix On Fri, Jul 13, 2007 at 09:24:44PM -0400, Mathieu Desnoyers wrote: > Since the immediate values depend on the same int3 handler as kprobes implements > for i386, we have to get architecture specific defines available for the kprobes > trap handler (especially restore_interrupts()) wven when CONFIG_KPROBES is not > selected. > > That kind of ifdef around a whole header does not make sense in the first place > anyway. > > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca> > CC: prasanna@...ibm.com > CC: ananth@...ibm.com > CC: anil.s.keshavamurthy@...el.com > CC: davem@...emloft.net > --- > include/linux/kprobes.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-2.6-lttng/include/linux/kprobes.h > =================================================================== > --- linux-2.6-lttng.orig/include/linux/kprobes.h 2007-07-13 18:47:57.000000000 -0400 > +++ linux-2.6-lttng/include/linux/kprobes.h 2007-07-13 18:48:45.000000000 -0400 > @@ -36,9 +36,9 @@ > #include <linux/spinlock.h> > #include <linux/rcupdate.h> > > -#ifdef CONFIG_KPROBES > #include <asm/kprobes.h> but this one isn't available on architectures that don't have kprobes, so you can't include linux/kprobes.h in generic code without ifdef protection anymore. I'd say move the code to asm/kdebug.h if it's need by more than just kprobes. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists