linux-kernel - Re: [GIT PULL][RESEND] KVM Updates for 2.6.23-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 15 Jul 2007 16:43:13 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Avi Kivity <avi@...ranet.com>
cc:	kvm-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL][RESEND] KVM Updates for 2.6.23-rc1



On Sat, 14 Jul 2007, Avi Kivity wrote:
>
> Linus, please do your usual thing from the repository and branch at

It has code like

	+       /* Can deadlock when called with interrupts disabled */
	+       WARN_ON(irqs_disabled());
	+
	        /* prevent preemption and reschedule on another processor */
	        int me = get_cpu();

which is against the coding conventions (and shouldn't even compile 
cleanly - but maybe we don't have the "warn about C99 variable 
declarations" thng on?).

Please don't do that.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/