linux-kernel - Re: [PATCH 1/12] drivers/isdn/hisax/avm_pci.c: replace pci_find_device with pci_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46996D12.40501@garzik.org>
Date:	Sat, 14 Jul 2007 20:40:50 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	caglar@...dus.org.tr
CC:	LKML <linux-kernel@...r.kernel.org>, kkeil@...e.de,
	kai.germaschewski@....de, isdn4linux@...tserv.isdn4linux.de,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/12] drivers/isdn/hisax/avm_pci.c: replace pci_find_device
 with pci_get_device

S.Çağlar Onur wrote:
> @@ -858,5 +858,10 @@ ready:
>  	cs->irq_func = &avm_pcipnp_interrupt;
>  	cs->writeisac(cs, ISAC_MASK, 0xFF);
>  	ISACVersion(cs, (cs->subtyp == AVM_FRITZ_PCI) ? "AVM PCI:" : "AVM PnP:");
> +	pci_dev_put(dev_avm);
>  	return (1);
> +
> +dev_avm_cleanup:
> +	pci_dev_put(dev_avm);
> +	return (0);
>  }


NAK -- every single one of these patches is wrong.  All you did was make 
the warning go away, while INTRODUCING new lifetime problems.

The ISDN PCI driver obviously continues execution after the setup 
function ends, yet you pci_dev_put() the device at the end of setup.  As 
a result, no reference is held even though we continue using the device.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/