linux-kernel - Re: [linux-usb-devel] [PATCH 01/02] USB: sierra: Add TRU-Install (c) Support [ATTEMPT 4]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200707161355.08548.oliver@neukum.org>
Date:	Mon, 16 Jul 2007 13:55:08 +0200
From:	Oliver Neukum <oliver@...kum.org>
To:	linux-usb-devel@...ts.sourceforge.net
Cc:	Kevin Lloyd <klloyd@...rrawireless.com>, gregkh@...e.de,
	linux@...rrawireless.com, torvalds@...l.org,
	linux-kernel@...r.kernel.org
Subject: Re: [linux-usb-devel] [PATCH 01/02] USB: sierra: Add TRU-Install (c) Support [ATTEMPT 4]

Am Freitag 13 Juli 2007 schrieb Kevin Lloyd:
> +int sierra_probe(struct usb_interface *iface, const struct usb_device_id *id)
> +{
> +       int result;     
> +       struct usb_device *udev;
> +
> +       udev = usb_get_dev(interface_to_usbdev(iface));
> +
> +       /* Check if in installer mode */
> +       if (id->driver_info == DEVICE_INSTALLER){
> +               dev_dbg(&udev->dev, "%s", "FOUND DEVICE(SW)\n");
> +               result = sierra_set_ms_mode(udev, SWIMS_SET_MODE_Modem);
> +               return result;

As I mentioned, you'd better return -EIO here. You don't want to bind
to the device, as it is not yet a serial device and you want the driver core
to stop trying while it goes away and transforms itself.

	Regards
		Oliver

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/