lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 16 Jul 2007 14:59:14 +0200 (CEST) From: Geert Uytterhoeven <Geert.Uytterhoeven@...ycom.com> To: Jens Axboe <jens.axboe@...cle.com> cc: James Bottomley <James.Bottomley@...elEye.com>, Arnd Bergmann <arnd@...db.de>, linux-scsi@...r.kernel.org, Linux Kernel Development <linux-kernel@...r.kernel.org>, Alessandro Rubini <rubini@...ion.unipv.it>, Linux/PPC Development <linuxppc-dev@...abs.org>, Paul Mackerras <paulus@...ba.org> Subject: Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver On Mon, 16 Jul 2007, Jens Axboe wrote: > On Mon, Jul 16 2007, Geert Uytterhoeven wrote: > > On Fri, 13 Jul 2007, Geert Uytterhoeven wrote: > > > Ah, that explains it. flush_dcache_page() is used in some drivers. > > > I'll update my patches. Thanks for the comments! > > > > Does this look OK? > > - Replaced KM_USER0 by KM_IRQ0 (all routines are either called from an > > interrupt handler, from .request_fn (ps3disk), or from .queuecommand > > (ps3rom)) > > That looks good. > > > - Add a call to flush_kernel_dcache_page() in routines that write to buffers > > Hmm, I would have thought a flush_dcache_page() would be more > appropriate, the backing could be page cache pages. OK, I'll change it to flush_dcache_page(). With kind regards, Geert Uytterhoeven Software Architect Sony Network and Software Technology Center Europe The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: Geert.Uytterhoeven@...ycom.com Internet: http://www.sony-europe.com/ Sony Network and Software Technology Center Europe A division of Sony Service Centre (Europe) N.V. Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium VAT BE 0413.825.160 · RPR Brussels Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619
Powered by blists - more mailing lists