linux-kernel - Re: sysctl.c: add text telling people to use CTL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070716112305.6308686f.randy.dunlap@oracle.com>
Date:	Mon, 16 Jul 2007 11:23:05 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Cc:	akpm <akpm@...ux-foundation.org>,
	torvalds <torvalds@...ux-foundation.org>
Subject: Re: sysctl.c: add text telling people to use CTL_UNNUMBERED

On Mon, 16 Jul 2007 18:02:43 GMT Linux Kernel Mailing List wrote:

> Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=2be7fe075af8f8ba9c8b8ab0feec4ba4fff04979
> Commit:     2be7fe075af8f8ba9c8b8ab0feec4ba4fff04979
> Parent:     97d8f83cb734525f96992fd61e4f7323ab3d549c
> Author:     Andrew Morton <akpm@...ux-foundation.org>
> AuthorDate: Sun Jul 15 23:41:21 2007 -0700
> Committer:  Linus Torvalds <torvalds@...dy.linux-foundation.org>
> CommitDate: Mon Jul 16 09:05:49 2007 -0700
> 
>     sysctl.c: add text telling people to use CTL_UNNUMBERED
>     
>     Hopefully this will help people to understand the new regime.
>     
>     Cc: "Eric W. Biederman" <ebiederm@...ssion.com>
>     Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
>     Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>
> ---
>  kernel/sysctl.c |   21 ++++++++++++++++++++-
>  1 files changed, 20 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/sysctl.c b/kernel/sysctl.c
> index 2cce228..7dca326 100644
> --- a/kernel/sysctl.c
> +++ b/kernel/sysctl.c
> @@ -203,7 +203,10 @@ static ctl_table root_table[] = {
>  		.mode		= 0555,
>  		.child		= dev_table,
>  	},
> -
> +/*
> + * NOTE: do not add new entries to this table unless you have read
> + * Documentation/sysctl/ctl_unnumbered.txt
> + */
>  	{ .ctl_name = 0 }
>  };
>  
> @@ -992,6 +995,14 @@ static ctl_table vm_table[] = {
>  		.extra1		= &zero,
>  	},
>  #endif
> +/*
> + * NOTE: do not add new entries to this table unless you have read
> + * Documentation/sysctl/ctl_unnumbered.txt
> + */
> +/*
> + * NOTE: do not add new entries to this table unless you have read
> + * Documentation/sysctl/ctl_unnumbered.txt
> + */
>  	{ .ctl_name = 0 }
>  };

Are these comments above &  below doubled up for Emphasis??

> @@ -1132,6 +1143,14 @@ static ctl_table fs_table[] = {
>  		.child		= binfmt_misc_table,
>  	},
>  #endif
> +/*
> + * NOTE: do not add new entries to this table unless you have read
> + * Documentation/sysctl/ctl_unnumbered.txt
> + */
> +/*
> + * NOTE: do not add new entries to this table unless you have read
> + * Documentation/sysctl/ctl_unnumbered.txt
> + */
>  	{ .ctl_name = 0 }
>  };


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/