linux-kernel - Re: [RFC PATCH 1/8] Convert the RCU tasklet into a softirq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070716204831.GA13539@elte.hu>
Date:	Mon, 16 Jul 2007 22:48:31 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Christoph Hellwig <hch@...radead.org>,
	john stultz <johnstul@...ibm.com>,
	Oleg Nesterov <oleg@...sign.ru>,
	Dipankar Sarma <dipankar@...ibm.com>,
	"David S. Miller" <davem@...emloft.net>, kuznet@....inr.ac.ru,
	Jonathan Corbet <corbet@....net>,
	Arjan van de Ven <arjan@...radead.org>,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [RFC PATCH 1/8] Convert the RCU tasklet into a softirq


* Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> On Mon, 16 Jul 2007, Paul E. McKenney wrote:
> >
> > On Wed, Jun 27, 2007 at 03:36:34PM -0400, Steven Rostedt wrote:
> > > I believe this was originally done by Dipankar Sarma. I pulled these
> > > changes from the -rt kernel.
> > > 
> > > For better preformance, RCU should use a softirq instead of a
> > > tasklet.
> > 
> > Acked-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> > Tested-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> > 
> > Tested with both kernbench and rcutorture on i386, x86_64, and ppc64.
> 
> Btw, are there any numbers on this? Is this whole thing actually 
> noticeable?

i doubt it's noticeable, because the RCU tasklet was not a "true" global 
tasklet, it was an array of tasklets put into a PER_CPU array. (which 
kind of defeats the purpose of tasklets)

So there should be no/little scalability disadvantage from this type of 
use of tasklets, and the tasklet use was at most a wart and a small, 
constant micro-cost that is likely masked by other costs. (and rcu never 
used any of the fancier tasklet ops like tasklet_disable() either)

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/