lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 16 Jul 2007 23:11:47 +0200 From: Joachim Fenkes <FENKES@...ibm.com> To: Roland Dreier <rdreier@...co.com> Cc: Christoph Raisch <raisch@...ibm.com>, "OF-General" <general@...ts.openfabrics.org>, Hoang-Nam Nguyen <hnguyen@...ibm.com>, LKML <linux-kernel@...r.kernel.org>, "LinuxPPC-Dev" <linuxppc-dev@...abs.org>, Roland Dreier <rolandd@...co.com>, Stefan Roscher <stefan.roscher@...ibm.com> Subject: Re: [PATCH 10/10] IB/ehca: Support large page MRs Roland Dreier <rdreier@...co.com> wrote on 16.07.2007 19:37:09: > > If enabled via the mr_largepage module parameter, > > Why the module parameter? Is there any reason a user would want to > turn this off? Or conversely, why is it off by default? We're pretty confident this new feature works, but as with all new and possibly experimental features, there are chances it might explode your machine when activated. So, like with the scaling code, we want the user to make the conscious decision of using this code instead of activating it by default. > > static ssize_t ehca_show_nr_eqs(struct device *dev, > > struct device_attribute *attr, > > char *buf) > > { > > return sprintf(buf, "%d\n", ehca_nr_eqs); > > } > > - > > static DEVICE_ATTR(nr_eqs, S_IRUGO, ehca_show_nr_eqs, NULL); > > Although trivial, this chunk doesn't really belong in this patch -- > just fix it up in the multiple EQ patch (which I haven't merged yet). Sure thing. Regards, Joachim - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists