[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070716235402.GE3318@linux-os.sc.intel.com>
Date: Mon, 16 Jul 2007 16:54:02 -0700
From: "Siddha, Suresh B" <suresh.b.siddha@...el.com>
To: mingo@...e.hu, nickpiggin@...oo.com.au
Cc: linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
clameter@....com
Subject: [patch] sched: fix the all pinned logic in load_balance_newidle()
nr_moved is not the correct check for triggering all pinned logic. Fix the
all pinned logic in the case of load_balance_newidle().
Signed-off-by: Suresh Siddha <suresh.b.siddha@...el.com>
---
diff --git a/kernel/sched.c b/kernel/sched.c
index 3332bbb..0cdac9c 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -2668,6 +2668,7 @@ load_balance_newidle(int this_cpu, struct rq *this_rq, struct sched_domain *sd)
unsigned long imbalance;
int nr_moved = 0;
int sd_idle = 0;
+ int all_pinned = 0;
cpumask_t cpus = CPU_MASK_ALL;
/*
@@ -2706,10 +2707,10 @@ redo:
double_lock_balance(this_rq, busiest);
nr_moved = move_tasks(this_rq, this_cpu, busiest,
minus_1_or_zero(busiest->nr_running),
- imbalance, sd, CPU_NEWLY_IDLE, NULL);
+ imbalance, sd, CPU_NEWLY_IDLE, &all_pinned);
spin_unlock(&busiest->lock);
- if (!nr_moved) {
+ if (unlikely(all_pinned)) {
cpu_clear(cpu_of(busiest), cpus);
if (!cpus_empty(cpus))
goto redo;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists