linux-kernel - Re: [PATCH] ivtv: don't recompile needlessly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Jul 2007 14:03:46 +0200 (CEST)
From:	"Hans Verkuil" <hverkuil@...all.nl>
To:	"Alexey Dobriyan" <adobriyan@...ru>
Cc:	akpm@...l.org, v4l-dvb-maintainer@...uxtv.org,
	linux-kernel@...r.kernel.org, hverkuil@...all.nl
Subject: Re: [PATCH] ivtv: don't recompile needlessly

> Driver prints 3l33t banner including kernel version.
> Could we _please_ never do this in future.

Thanks for reporting this. This was a leftover from when the driver was
standalone. I've merged this patch in my repository and will push it
upstream.

Regards,

        Hans

>
> Signed-off-by: Alexey Dobriyan <adobriyan@...ru>
> ---
>
>  drivers/media/video/ivtv/ivtv-driver.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> --- a/drivers/media/video/ivtv/ivtv-driver.c
> +++ b/drivers/media/video/ivtv/ivtv-driver.c
> @@ -56,7 +56,6 @@
>  #include "ivtv-gpio.h"
>  #include "ivtv-yuv.h"
>
> -#include <linux/vermagic.h>
>  #include <media/tveeprom.h>
>  #include <media/v4l2-chip-ident.h>
>
> @@ -1315,7 +1314,7 @@ static struct pci_driver ivtv_pci_driver = {
>  static int module_start(void)
>  {
>  	printk(KERN_INFO "ivtv:  ==================== START INIT IVTV
> ====================\n");
> -	printk(KERN_INFO "ivtv:  version %s (" VERMAGIC_STRING ") loading\n",
> IVTV_VERSION);
> +	printk(KERN_INFO "ivtv:  version %s loading\n", IVTV_VERSION);
>
>  	memset(ivtv_cards, 0, sizeof(ivtv_cards));
>
>
>


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/