linux-kernel - Re: [PATCH] Fix leaks on /proc/{*/sched,sched_debug,timer_list,timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070717123511.GB17657@elte.hu>
Date:	Tue, 17 Jul 2007 14:36:10 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Alexey Dobriyan <adobriyan@...ru>
Cc:	akpm@...l.org, linux-kernel@...r.kernel.org, devel@...nvz.org,
	Thomas Gleixner <tglx@...utronix.de>, stable@...nel.org
Subject: Re: [PATCH] Fix leaks on
	/proc/{*/sched,sched_debug,timer_list,timer_stats}


* Alexey Dobriyan <adobriyan@...ru> wrote:

> On every open/close one struct seq_operations leaks.
> Kudos to /proc/slab_allocators.
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@...ru>

ouch ...

Acked-by: Ingo Molnar <mingo@...e.hu>

-stable material too, as far as timer_info/stats goes.

> -       .release        = seq_release,
> +       .release        = single_release,

i think seq_release() definitely needs to grow a WARN_ON() if it's being 
used on an inode that was opened via single_open(). This bug is so 
easily committed, and nothing but a small leak reminds us on it.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/