linux-kernel - Re: [PATCH] introduce __init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070717130230.GB24780@uranus.ravnborg.org>
Date:	Tue, 17 Jul 2007 15:02:30 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Domen Puncer <domen.puncer@...argo.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] introduce __init_exit function annotation

On Tue, Jul 17, 2007 at 10:02:48AM +0200, Domen Puncer wrote:
> Introduce __init_exit, which is useful ie. for drivers that call
> cleanup functions when they fail in __init functions.

This is wrong.
On arm (just one example of several) the __exit section are discarded
at buildtime so any reference from __init to __exit will cause the
linker to error out.

The real solution is only to declare functiones used solely during
exit as __exit.
The whole point of using __exit is to tell that this can be safely
dropped when built-in because it is not used then.

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/