linux-kernel - Re: [PATCH 05/17] lib: percpu_count_sum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070717163558.GC15421@filer.fsl.cs.sunysb.edu>
Date:	Tue, 17 Jul 2007 12:35:58 -0400
From:	Josef Sipek <jsipek@....cs.sunysb.edu>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	miklos@...redi.hu, akpm@...ux-foundation.org, neilb@...e.de,
	dgc@....com, tomoki.sekiyama.qu@...achi.com, nikita@...sterfs.com,
	trond.myklebust@....uio.no, yingchao.zhou@...il.com, andrea@...e.de
Subject: Re: [PATCH 05/17] lib: percpu_count_sum_signed()

On Tue, Jul 17, 2007 at 12:32:43PM -0400, Josef Sipek wrote:
> On Thu, Jun 14, 2007 at 11:58:22PM +0200, Peter Zijlstra wrote:
> > Provide an accurate version of percpu_counter_read.
> > 
> > Should we go and replace the current use of percpu_counter_sum()
> > with percpu_counter_sum_positive(), and call this new primitive
> > percpu_counter_sum() instead?
> > 
> > Signed-off-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> > ---
> >  include/linux/percpu_counter.h |   18 +++++++++++++++++-
> >  lib/percpu_counter.c           |    6 +++---
> >  2 files changed, 20 insertions(+), 4 deletions(-)
> > 
> > Index: linux-2.6/include/linux/percpu_counter.h
> > ===================================================================
> > --- linux-2.6.orig/include/linux/percpu_counter.h	2007-05-23 20:37:54.000000000 +0200
> > +++ linux-2.6/include/linux/percpu_counter.h	2007-05-23 20:38:09.000000000 +0200
> > @@ -35,7 +35,18 @@ void percpu_counter_destroy(struct percp
> >  void percpu_counter_set(struct percpu_counter *fbc, s64 amount);
> >  void __percpu_counter_mod(struct percpu_counter *fbc, s32 amount, s32 batch);
> >  void __percpu_counter_mod64(struct percpu_counter *fbc, s64 amount, s32 batch);
> > -s64 percpu_counter_sum(struct percpu_counter *fbc);
> > +s64 __percpu_counter_sum(struct percpu_counter *fbc);
> > +
> > +static inline s64 percpu_counter_sum(struct percpu_counter *fbc)
> > +{
> > +	s64 ret = __percpu_counter_sum(fbc);
> > +	return ret < 0 ? 0 : ret;
> 
> max(0, ret) maybe?
> 
> Josef 'Jeff' Sipek.

Ok, replying to email that's more than a month old may not be the best idea
:)

Josef 'Jeff' Sipek.

-- 
We have joy, we have fun, we have Linux on a Sun...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/