linux-kernel - Re: [PATCH] appletouch powersaving - please apply for 2.6.23-rc1 take #3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1184696179.6161.18.camel@localhost>
Date:	Tue, 17 Jul 2007 20:16:19 +0200
From:	Soeren Sonnenburg <kernel@....de>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	linux-input@...ey.karlin.mff.cuni.cz,
	linux-usb-devel@...ts.sourceforge.net,
	Matthew Garrett <mjg59@...f.ucam.org>,
	Nicolas Boichat <nicolas@...chat.ch>,
	Michael Hanselmann <linux-kernel@...smi.ch>,
	Peter Osterlund <petero2@...ia.com>,
	Frank Arnold <frank@...rocco-5v-turbo.de>,
	Stelian Pop <stelian@...ies.net>,
	Johannes Berg <johannes@...solutions.net>,
	Greg Kroah-Hartman <greg@...ah.com>
Subject: Re: [PATCH] appletouch powersaving - please apply for 2.6.23-rc1
	take #3

On Tue, 2007-07-17 at 11:01 -0400, Dmitry Torokhov wrote:
> Hi,
> 
> On 7/17/07, Soeren Sonnenburg <kernel@....de> wrote:
> >
> >  err_free_buffer:
> > @@ -656,6 +699,7 @@ static void atp_disconnect(struct usb_interface *iface)
> >
> >        usb_set_intfdata(iface, NULL);
> >        if (dev) {
> > +               cancel_work_sync(&dev->work);
> >                usb_kill_urb(dev->urb);
> >                input_unregister_device(dev->input);
> >                usb_buffer_free(dev->udev, dev->datalen,
> >
> 
> This should go into atp_close() and I think you need to do
> cancel_work_sync after calling usb_kill_urb() otherwise you risk it
> being submitted while you gettingto kill the urb.

good catch. modified patch accordingly+attached.

> How many boxes did you try this patch on?

Mine plus 1 other. However please note that Matthews patch has been
(which is what this patch is based on) is in the mactel-patches
repository for quite some time now and that the not-yet-cleanup up
variant of this patch was posted to mactel-devel...

So the modeswitch part should work...

Soeren
-- 
Sometimes, there's a moment as you're waking, when you become aware of
the real world around you, but you're still dreaming.

View attachment "appletouch3.patch" of type "text/x-patch" (5005 bytes)