linux-kernel - Re: [PATCH] fs/9p/v9fs.c: Delete unused p9_debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070717190508.GH3801@stusta.de>
Date:	Tue, 17 Jul 2007 21:05:08 +0200
From:	Adrian Bunk <bunk@...sta.de>
To:	"Horst H. von Brand" <vonbrand@....utfsm.cl>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	v9fs-developer@...ts.sourceforge.net
Subject: Re: [PATCH] fs/9p/v9fs.c: Delete unused p9_debug_level setting

On Tue, Jul 17, 2007 at 02:26:06PM -0400, Horst H. von Brand wrote:
> From: Horst H. von Brand <vonbrand@....utfsm.cl>
> 
> Signed-off-by: Horst H. von Brand <vonbrand@....utfsm.cl>
> ---
>  fs/9p/v9fs.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/9p/v9fs.c b/fs/9p/v9fs.c
> index 45c3598..72ad365 100644
> --- a/fs/9p/v9fs.c
> +++ b/fs/9p/v9fs.c
> @@ -131,7 +131,6 @@ static void v9fs_parse_options(char *options, struct v9fs_session_info *v9ses)
>  		switch (token) {
>  		case Opt_debug:
>  			v9ses->debug = option;
> -			p9_debug_level = option;
>  			break;
>  		case Opt_port:
>  			v9ses->port = option;

It doesn't seem to be unused:

$ grep -r p9_debug_level *
fs/9p/v9fs.c:                   p9_debug_level = option;
include/net/9p/9p.h:extern unsigned int p9_debug_level;
include/net/9p/9p.h:    if ((p9_debug_level & level) == level) \
net/9p/mod.c:unsigned int p9_debug_level = 0;   /* feature-rific global debug level  */
net/9p/mod.c:EXPORT_SYMBOL(p9_debug_level);
net/9p/mod.c:module_param_named(debug, p9_debug_level, uint, 0);
net/9p/mux.c:           if ((p9_debug_level&P9_DEBUG_FCALL) == P9_DEBUG_FCALL) {
net/9p/mux.c:   if ((p9_debug_level&P9_DEBUG_FCALL) == P9_DEBUG_FCALL) {
net/9p/sysctl.c:                .data           = &p9_debug_level,
$ 

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/