| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 17 Jul 2007 12:18:21 -0700 From: Andrew Morton <akpm@...ux-foundation.org> To: Jens Axboe <jens.axboe@...cle.com> Cc: FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>, linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org Subject: Re: block/bsg.c On Tue, 17 Jul 2007 08:38:11 +0200 Jens Axboe <jens.axboe@...cle.com> wrote: > > In terms of presentation: this code hit the tree as base patch plus what > > appear to be 20 bugfixes, none of which are really interesting or relevant > > to mainline. Personally I think it would be nicer if all that out-of-tree > > development work was cleaned up and the new code goes in as a single hit. > > > > This makes it a lot easier to find out "wtf does this code all do". One > > finds the first commit and reads the changlog. But this algorithm yields: > > > > bsg: support for full generic block layer SG v3 > > > > which is not helpful. > > I agree, I did consider rebasing the merging all patches into a single > commit prior to submission. In retrospect that would have been better, > the bug fixes commits prior to inclusion is not that interesting. I'm doing a git-bisect and.... block/bsg.c: In function 'bsg_register_queue': block/bsg.c:1014: error: 'struct kobject' has no member named 'dentry' That's easily fixable in config, but it's another reason for doing that consolidation prior to merging. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists