linux-kernel - Re: regression: disk error loop (panic?) ide_do_rw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Jul 2007 14:24:21 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
cc:	Giacomo Catenazzi <cate@...eee.net>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Jens Axboe <jens.axboe@...cle.com>, akpm@...ux-foundation.org
Subject: Re: regression: disk error loop (panic?) ide_do_rw_disk-bad:

On Tue, 17 Jul 2007, Bartlomiej Zolnierkiewicz wrote:
> 
> ide-disk driver and type 2 (REQ_TYPE_BLOCK_PC) requests don't mix well
> 
> Probably some dumb application is sending packet commands without
> checking the device type...

Ok, we should definitely try to just translate the things, and instead of 
having user apps that have to know about the (generally not very 
interesting) differences between IDE and SCSI command set, and when the 
IDE driver gets a SCSI request (whether from the new generic SG layer or 
obviously the older SCSI-ioctl layer) it should "just work".

So I object to that "dumb application" statement. It's the kernel that has 
traditionally been dumb in not smoothing over the differences between 
devices well enough.

We shouldn't _need_ to have applications care. They should be able to just 
use regular SCSI commands, and if the device cannot handle a 10-byte read 
command, the kernel should have translated that into a 6-byte one (for 
example) rather than the application having to know about idiotic small 
differences like that.

That said, I dunno how to fix this particular one, and the IDE driver is 
singularly unhelpful in actually talking about *what* the command tried to 
be.

			Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/