linux-kernel - Re: regression: disk error loop (panic?) ide_do_rw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.0.999.0707171535170.27353@woody.linux-foundation.org>
Date:	Tue, 17 Jul 2007 15:38:18 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
cc:	Giacomo Catenazzi <cate@...eee.net>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Jens Axboe <jens.axboe@...cle.com>, akpm@...ux-foundation.org
Subject: Re: regression: disk error loop (panic?) ide_do_rw_disk-bad:



On Wed, 18 Jul 2007, Bartlomiej Zolnierkiewicz wrote:
> 
> The new generic SG layer is CONFIG_SCSI=y "generic" in the current tree.

Yeah. I know, I already talked to Jens about it - in order to be generic, 
the BSG stuff really does end up having to be able to stand on its own, 
since not everybody wants/needs the whole SCSI layer.

> > obviously the older SCSI-ioctl layer) it should "just work".
> 
> Agreed but IDE driver has never claimed to have full SAT layer and
> full SCSI-ioctl layer support has been provided only for ide-cd.

I agree, and understand why it happened, but hope that maybe it can be 
improved in the future, or at least the error returned earlier so that the 
request will never even hit the ATA device at all if the IDE layer cannot 
then handle it.

> For now it should be sufficient to revert ide.c chunks of
> 
> commit 3d6392cfbd7dc11f23058e3493683afab4ac13a3

Jens?

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/