linux-kernel - Re: a52b1752c07 broke !SMP: error: implicit declaration of function `WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070717235400.GQ21668@ftp.linux.org.uk>
Date:	Wed, 18 Jul 2007 00:54:00 +0100
From:	Al Viro <viro@....linux.org.uk>
To:	Uwe Kleine-K?nig <ukleinek@...ormatik.uni-freiburg.de>,
	Avi Kivity <avi@...ranet.com>, linux-kernel@...r.kernel.org
Subject: Re: a52b1752c07 broke !SMP: error: implicit declaration of function `WARN_ON'

On Wed, Jul 18, 2007 at 01:24:46AM +0200, Uwe Kleine-K?nig wrote:
> Hello,
> 
> kernel/timer.c (and some others as arch/arm/kernel/irq.c) include
> <linux/smp.h>, but not <linux/kernel.h>
> 
> a52b1752c07 introduces usage of the WARN_ON macro in <linux/smp.h>, but
> doesn't pull in <linux/kernel.h>.  (<asm/bug.h> is not enough, at least
> for arm, because WARN_ON uses printk there.)
> 
> The obvious options are:
> 
> 1) include <linux/kernel.h> in <linux/smp.h>, maybe conditioned by !SMP
> 2) include <linux/kernel.h> in all includers of <linux/smp.h>
> 3) remove the WARN_ONs introduced by a52b1752c07.
> 
> WARN_ON is used in an inline function that isn't used in every file
> including <linux/smp.h>, so maybe updating the compiler might make
> the effort for 2) smaller!?  (I'm using gcc 3.4.4)

4) turn the sucker into macro
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/