linux-kernel - Re: [PATCH 0/2] SELinux Netlabel updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.0.999.0707171719320.27353@woody.linux-foundation.org>
Date:	Tue, 17 Jul 2007 17:24:55 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	James Morris <jmorris@...ei.org>
cc:	Stephen Smalley <sds@...ho.nsa.gov>,
	Paul Moore <paul.moore@...com>, linux-kernel@...r.kernel.org,
	michal.k.k.piotrowski@...il.com
Subject: Re: [PATCH 0/2] SELinux Netlabel updates



On Tue, 17 Jul 2007, James Morris wrote:
> 
> These are updated Netlabel/SELinux changes from Paul, reworked so that 
> they don't break userspace.  Michal says they work for him.  Please apply 
> for 2.6.23.

They don't work AT ALL for me:

	security/selinux/ss/sidtab.o: In function `netlbl_enabled':
	sidtab.c:(.text+0x0): multiple definition of `netlbl_enabled'
	security/selinux/ss/ebitmap.o:ebitmap.c:(.text+0x0): first defined here

Tssk.

That dummy "netlbl_enabled()" should be "static inline", methinks.

Also, that <net/netlabel.h> file has two blocks after each other of

	#ifdef CONFIG_NETLABEL
	..
	#else
	..
	#endif

	#ifdef CONFIG_NETLABEL
	..
	#else
	..
	#endif

which might as well be cleaned up at the same time (and might have avoided 
this bug, since then the people involved would have seen the _correct_ 
example in the first version)

Please fix up and ask me to pull again. Preferably by actually fixing up 
the commit itself, so that we don't unnecessarily have revisions that 
don't even compile and thus potentially screw up git-bisect attempts.

			Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/