linux-kernel - Re: [PATCH 1/3] drivers/base/core: improve device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <469DCC4A.9010001@garzik.org>
Date:	Wed, 18 Jul 2007 04:16:10 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Cornelia Huck <cornelia.huck@...ibm.com>
CC:	LKML <linux-kernel@...r.kernel.org>, Greg KH <greg@...ah.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/3] drivers/base/core: improve device_add() error handling,
 fix bugs

Cornelia Huck wrote:
> On Wed, 18 Jul 2007 01:53:48 -0400,
> Jeff Garzik <jeff@...zik.org> wrote:
> 
>> The following change was checked into 'warnings' branch of
>> git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git
>>
>> commit 5330916f5a11d8b7def46a6b3e14a831684032f5
>> Author: Jeff Garzik <jeff@...zik.org>
>> Date:   Wed Jul 18 01:41:29 2007 -0400
>>
>>     drivers/base/core: improve device_add() error handling, fix bugs
>>     
>>     * silence several warnings by handling sysfs_create_link() failure
>>     
>>     * re-order some operations in error handling, to precisely reverse
>>       the order of operations, i.e. unwind properly.
>>     
>>     Signed-off-by: Jeff Garzik <jeff@...zik.org>
>>
>>  drivers/base/core.c |   46 ++++++++++++++++++++++++++++++----------------
>>  1 file changed, 30 insertions(+), 16 deletions(-)
> 
> Hm, what about driver-core-check-return-code-of-sysfs_create_link.patch
> (merged with ...-fix.patch) which has been in -mm for a while?

No idea, I didn't check there.   If someone else has a better patch... 
great!  Let's merge it :)

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/