[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5540.1184750615@redhat.com>
Date: Wed, 18 Jul 2007 10:23:35 +0100
From: David Howells <dhowells@...hat.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] AFS: Fix file locking
Andrew Morton <akpm@...ux-foundation.org> wrote:
> Here we use
>
> vnode->flags & (1 << foo)
>
> > + set_bit(AFS_VNODE_LOCKING, &vnode->flags);
>
> and elsewhere we use set_bit(foo, &vnode->flags) and clear_bit()
Ah... IIRC I was originally testing multiple bits in one go (test_bit()'s do
not merge because of the volatile pointer).
However, as I'm doing only one test now, I'll convert it to test_bit().
David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists