linux-kernel - Re: [PATCH] smp_call_function_single() should be a macro on UP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070718000045.GR21668@ftp.linux.org.uk>
Date:	Wed, 18 Jul 2007 01:00:45 +0100
From:	Al Viro <viro@....linux.org.uk>
To:	Ben Dooks <ben@...ff.org>
Cc:	David Miller <davem@...emloft.net>, torvalds@...ux-foundation.org,
	linux-kernel@...r.kernel.org, avi@...ranet.com
Subject: Re: [PATCH] smp_call_function_single() should be a macro on UP

On Wed, Jul 18, 2007 at 12:54:17AM +0100, Ben Dooks wrote:
> This has broken _all_ ARM builds, due to using WARN_ON()
> in this header. Warn on needs <asm/bug.h> and this is
> needs <linux/kernel.h> to make it compile cleanly on ARM
> which is unfortuantely what we where trying to avoid in
> the first place?
> 
> This patch fixes the compile on ARM, but moves the
> includes out of the CONFIG_SMP block.

Which "this" are you refering to?  Original introduction of inline
or switch to a macro on top of it?

FWIW, with "turn to macro" all arm builds I have here pass fine.
Please, check if current Linus' tree (already with that patch)
works for you; I very much object to pulling more includes in
there, that way lies a lot of breakage.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/