linux-kernel - Re: [PATCH] sysfs: fix sysfs root inode nlink accounting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 18 Jul 2007 16:02:11 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	Tejun Heo <htejun@...il.com>
Cc:	Greg KH <gregkh@...e.de>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sysfs: fix sysfs root inode nlink accounting

Hi Tejun,

On Wed, 18 Jul 2007 14:29:06 +0900, Tejun Heo wrote:
> While making sysfs indoes hashed, sysfs root inode was left out.  Now
> that nlink accounting depends on the inode being on the hash, sysfs
> root inode nlink isn't adjusted properly.
> 
> Put sysfs root inode on the inode hash by allocating it using
> sysfs_get_inode() like other sysfs inodes.  While at it, massage
> comments a bit.

This fixed my problem as expected. Thanks a lot!

> Signed-off-by: Tejun Heo <htejun@...il.com>

For what it's worth:

Acked-by: Jean Delvare <khali@...ux-fr.org>

> ---
>  fs/sysfs/mount.c |   10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> Index: work/fs/sysfs/mount.c
> ===================================================================
> --- work.orig/fs/sysfs/mount.c
> +++ work/fs/sysfs/mount.c
> @@ -43,19 +43,19 @@ static int sysfs_fill_super(struct super
>  	sb->s_time_gran = 1;
>  	sysfs_sb = sb;
>  
> -	inode = new_inode(sysfs_sb);
> +	/* get root inode, initialize and unlock it */
> +	inode = sysfs_get_inode(&sysfs_root);
>  	if (!inode) {
>  		pr_debug("sysfs: could not get root inode\n");
>  		return -ENOMEM;
>  	}
>  
> -	sysfs_init_inode(&sysfs_root, inode);
> -
>  	inode->i_op = &sysfs_dir_inode_operations;
>  	inode->i_fop = &sysfs_dir_operations;
> -	/* directory inodes start off with i_nlink == 2 (for "." entry) */
> -	inc_nlink(inode);
> +	inc_nlink(inode); /* directory, account for "." */
> +	unlock_new_inode(inode);
>  
> +	/* instantiate and link root dentry */
>  	root = d_alloc_root(inode);
>  	if (!root) {
>  		pr_debug("%s: could not get root dentry!\n",__FUNCTION__);


-- 
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/