linux-kernel - Re: [Linux-fbdev-devel] [PATCH] fbdev: find mode with highest refresh rate in fb_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1184771895.4523.33.camel@daplas>
Date:	Wed, 18 Jul 2007 23:18:15 +0800
From:	"Antonino A. Daplas" <adaplas@...il.com>
To:	linux-fbdev-devel@...ts.sourceforge.net
Cc:	Michal Januszewski <spock@...too.org>,
	linux-kernel@...r.kernel.org,
	Ondrej Zajicek <santiago@...reenet.org>
Subject: Re: [Linux-fbdev-devel] [PATCH] fbdev: find mode with highest
	refresh rate in fb_find_mode()

On Wed, 2007-07-18 at 16:38 +0200, Ondrej Zajicek wrote:
> On Wed, Jul 18, 2007 at 10:41:02AM +0200, Michal Januszewski wrote:
> > Currently if the refresh rate is not specified fb_find_mode() returns
> > the first known video mode with the requested resoluion, which provides
> > no guarantees wrt the refresh rate.  Change this so that the mode with
> > the highest refresh rate is returned instead.
> 
> What refresh rate it sets when used on card or monitor without DDC?

Yes, I noted this also while reviewing patches.  fb_find_mode() is used
predominantly with the 'generic' modedb which contains modes that are
not specific to the card or monitor.  And fb_try_mode() is not a
guarantee that the returned refresh rate will be safe (we have a lot of
drivers that do not check the timings against the display capabilities).

It would be best that fb_find_mode() return the safest refresh rate
(60Hz) instead of the highest.

Tony

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/