linux-kernel - Re: [PATCH] sysfs: kill an extra put in sysfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a781481a0707180908o68102680o5590722127ba9b02@mail.gmail.com>
Date:	Wed, 18 Jul 2007 21:38:40 +0530
From:	"Satyam Sharma" <satyam.sharma@...il.com>
To:	"Tejun Heo" <htejun@...il.com>
Cc:	"Gabriel C" <nix.or.die@...glemail.com>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
	"Christoph Lameter" <clameter@....com>, gregkh@...e.de,
	miles.lane@...il.com
Subject: Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path

On 7/18/07, Tejun Heo <htejun@...il.com> wrote:
> Satyam Sharma wrote:
> > A trivial nit:
> >
> > The cleanup ignores the return of sysfs_addrm_finish() -- functions
> > such as those could and should be void-returning. It doesn't even
> > need to return an int for success / failure ... I went over it's code,
> > and it's obvious that the function just never fails!
> >
> > Returning the count of objects actually added / removed is quite
> > redundant too, because we return "actx->cnt" unconditionally
> > from inside it, and the caller can know that anyway, without
> > even calling it. Also, note that nowhere in the present code is
> > the return of that function ever being used in that sense (i.e. as
> > a "count") anyway ...
> >
> > So: best to just make it void-returning. That's what it is.
>
> Oh well, the function was made that way because that made the conversion
> easier when add/rm paths were consolidated using sysfs_addrm_cxt and
> friends.  So, if you see the detail as a problem, please submit a patch.
>  I dunno whether I would agree with the patch or not without seeing one.

Ok, I'll submit one then.

Thanks,
Satyam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/