linux-kernel - Re: 2.6.22-git* regression: Kconfig prompts without help text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 18 Jul 2007 20:33:27 +0200 (CEST)
From:	Jan Engelhardt <jengelh@...putergmbh.de>
To:	Randy Dunlap <randy.dunlap@...cle.com>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Stefan Richter <stefanr@...6.in-berlin.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Michal Piotrowski <michal.k.k.piotrowski@...il.com>
Subject: Re: 2.6.22-git* regression: Kconfig prompts without help text


On Jul 18 2007 11:04, Randy Dunlap wrote:
>> > I have no idea where it came from.  (not me)
>> 
>> It was akpm:
>> http://linux.bkbits.net:8080/linux-2.6/Documentation/CodingStyle?PAGE=diffs&REV=1.5
>
> I think that would only make sense if "---help---" is used (like you did)
> instead of the plain "help" string.
>
> In the case of "---help---", it's OK with me not to be indented by 2 more
> spaces.

===

kconf also accepts "---help---" besides the usual "help" keyword.
If it is used, I think we can omit the extra spaces, because the
dashes are visible enough a sash.

Signed-off-by: Jan Engelhardt <jengelh@....de>

---
 Documentation/CodingStyle |   13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

Index: linux-2.6.23/Documentation/CodingStyle
===================================================================
--- linux-2.6.23.orig/Documentation/CodingStyle
+++ linux-2.6.23/Documentation/CodingStyle
@@ -511,17 +511,16 @@ remember: "indent" is not a fix for bad 
 
 For all of the Kconfig* configuration files throughout the source tree,
 the indentation is somewhat different.  Lines under a "config" definition
-are indented with one tab, while help text is indented an additional two
-spaces.  Example:
+are indented with one tab. Example:
 
 config AUDIT
 	bool "Auditing support"
 	depends on NET
-	help
-	  Enable auditing infrastructure that can be used with another
-	  kernel subsystem, such as SELinux (which requires this for
-	  logging of avc messages output).  Does not do system-call
-	  auditing without CONFIG_AUDITSYSCALL.
+	---help---
+	Enable auditing infrastructure that can be used with another
+	kernel subsystem, such as SELinux (which requires this for
+	logging of avc messages output).  Does not do system-call
+	auditing without CONFIG_AUDITSYSCALL.
 
 Features that might still be considered unstable should be defined as
 dependent on "EXPERIMENTAL":
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/