linux-kernel - Re: [git patches 1/2] warnings: attack valid cases spotted by warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 18 Jul 2007 16:03:05 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Greg KH <gregkh@...e.de>
CC:	akpm@...ux-foundation.org, torvalds@...ux-foundation.org,
	linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org,
	chas@....nrl.navy.mil, rolandd@...co.com, dwmw2@...radead.org
Subject: Re: [git patches 1/2] warnings: attack valid cases spotted by	warnings

Greg KH wrote:
> On Tue, Jul 17, 2007 at 05:42:39PM -0400, Jeff Garzik wrote:
>> commit ae97fec3701a559929c3529e35417fab133a4d39
>> Author: Jeff Garzik <jeff@...zik.org>
>> Date:   Tue Jul 17 01:08:29 2007 -0400
>>
>>     drivers/usb/misc/auerswald: fix status check, remove redundant check
>>     
>>     1) We should only set 'actual_length' output variable if usb length is
>>     known to be good.
>>     
>>     2) No need to check actual_length for NULL.  The only caller always
>>     passes non-NULL value.
>>     
>>     Signed-off-by: Jeff Garzik <jeff@...zik.org>
> 
> I have no objection to this patch at all, however it does not remove the
> compiler warning :(

The description doesn't say it removes a warning, so it doesn't :)

You want to look at

	drivers/*: mark variables with uninitialized_var()

which was in posting "[git patches 2/2] warnings: use 
uninitialized_var()" and is now upstream commit 
a6343afb6e16b65b9f0b264f94f8207212e7e3ae

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/