linux-kernel - Re: [PATCH][RFC] Delete export of tty.h to userspace.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <469E7599.4060608@gmail.com>
Date:	Wed, 18 Jul 2007 22:18:33 +0200
From:	Jiri Slaby <jirislaby@...il.com>
To:	"Robert P. J. Day" <rpjday@...dspring.com>
CC:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [PATCH][RFC] Delete export of tty.h to userspace.

Robert P. J. Day napsal(a):
> Signed-off-by: Robert P. J. Day <rpjday@...dspring.com>
> 
> ---
> 
>   given that the entire contents of include/linux/tty.h is contained
> within an "#ifdef __KERNEL__", it seems pointless to export it to
> userspace, unless there's some kind of need for that header file to
> exist in userspace, even if it's empty.
> 
>   a quick grep shows that nothing under /usr/include references any
> file of the name "tty.h" in any way.  thoughts?

If we decide to remove the file, I would rather go through deprecation of the
file with filing an entry in feature-remove-schedule. There still seems to be
some users of the file.

With deprecation done with sth. like
#ifndef __KERNEL__
#warning Don't include this file from userspace, it's emtpy.
#endif

>  diff --git a/include/linux/Kbuild b/include/linux/Kbuild
> index 4ff0f57..63de91a 100644
> --- a/include/linux/Kbuild
> +++ b/include/linux/Kbuild
> @@ -328,7 +327,6 @@ unifdef-y += sysctl.h
>  unifdef-y += tcp.h
>  unifdef-y += time.h
>  unifdef-y += timex.h
> -unifdef-y += tty.h
>  unifdef-y += types.h
>  unifdef-y += udf_fs_i.h
>  unifdef-y += udp.h


-- 
Jiri Slaby (jirislaby@...il.com)
Faculty of Informatics, Masaryk University
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/