linux-kernel - RE: ia64 build failure from recent diskquota patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1184795494.3026.21.camel@deimos.americas.hpqcorp.net>
Date:	Wed, 18 Jul 2007 17:51:34 -0400
From:	Doug Chapman <doug.chapman@...com>
To:	"Luck, Tony" <tony.luck@...el.com>
Cc:	linux-kernel@...r.kernel.org, linux-ia64@...r.kernel.org,
	vtaras@...nvz.org
Subject: RE: ia64 build failure from recent diskquota patch

On Wed, 2007-07-18 at 14:45 -0700, Luck, Tony wrote:
> > The type compat_u64 on ia64 is defined if CONFIG_COMPAT is defined
> > (which is rare these days on ia64)  So, it appears we are missing
> > an #ifdef CONFIG_COMPAT somewhere in fs/quota.c.  I will leave that
> > up to the original author to determine where.
> 
> Hmmmm ... all of my test config files have CONFIG_COMPAT=y, so I didn't
> notice this.  I'll have to fix one of them to turn it off.
> 
> Perhaps this (untested) is what is needed?
> 
> diff --git a/fs/quota.c b/fs/quota.c
> index e6577ac..ac3af87 100644
> --- a/fs/quota.c
> +++ b/fs/quota.c
> @@ -387,7 +387,7 @@ asmlinkage long sys_quotactl(unsigned int cmd, const char __user *special, qid_t
>  	return ret;
>  }
>  
> -#if defined(CONFIG_X86_64) || defined(CONFIG_IA64)
> +#if defined(CONFIG_X86_64) || (defined(CONFIG_IA64) && defined(CONFIG_COMPAT))
>  /*
>   * This code works only for 32 bit quota tools over 64 bit OS (x86_64, ia64)
>   * and is necessary due to alignment problems.

Works for me, compiles just fine now.

ACK

- Doug


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/