[<prev] [next>] [day] [month] [year] [list]
Message-Id: <200707190130.39067.jesper.juhl@gmail.com>
Date: Thu, 19 Jul 2007 01:30:38 +0200
From: Jesper Juhl <jesper.juhl@...il.com>
To: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Cc: Thomas Hellstrom <thomas@...gstengraphics.com>,
Alan Hourihane <alanh@...gstengraphics.com>,
Jesper Juhl <jesper.juhl@...il.com>
Subject: [PATCH] cr_backlight_probe allocates too little storage for struct cr_panel
Hi,
The Coverity checker noticed that we allocate too little storage
for "struct cr_panel *crp" in cr_backlight_probe().
We allocate sizeof(crp) where we should really be
allocating sizeof(*crp) - or sizeof(struct cr_panel) - I
chose the first notation.
This patch should fix the problem.
Signed-off-by: Jesper Juhl <jesper.juhl@...il.com>
---
drivers/video/backlight/cr_bllcd.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/backlight/cr_bllcd.c b/drivers/video/backlight/cr_bllcd.c
index e9bbc34..1b3f658 100644
--- a/drivers/video/backlight/cr_bllcd.c
+++ b/drivers/video/backlight/cr_bllcd.c
@@ -174,7 +174,7 @@ static int cr_backlight_probe(struct platform_device *pdev)
struct cr_panel *crp;
u8 dev_en;
- crp = kzalloc(sizeof(crp), GFP_KERNEL);
+ crp = kzalloc(sizeof(*crp), GFP_KERNEL);
if (crp == NULL)
return -ENOMEM;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists