linux-kernel - Re: [PATCH] vmalloc_32 should use GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Jul 2007 23:33:58 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:	Linux Kernel list <linux-kernel@...r.kernel.org>,
	linux-mm@...ck.org, Dave Airlie <airlied@...il.com>,
	Andi Kleen <ak@...e.de>
Subject: Re: [PATCH] vmalloc_32 should use GFP_KERNEL

On Wed, 18 Jul 2007 16:25:34 +1000 Benjamin Herrenschmidt <benh@...nel.crashing.org> wrote:

> I've noticed lots of failures of vmalloc_32 on machines where it
> shouldn't have failed unless it was doing an atomic operation.
> 
> Looking closely, I noticed that:
> 
> #if defined(CONFIG_64BIT) && defined(CONFIG_ZONE_DMA32)
> #define GFP_VMALLOC32 GFP_DMA32
> #elif defined(CONFIG_64BIT) && defined(CONFIG_ZONE_DMA)
> #define GFP_VMALLOC32 GFP_DMA
> #else
> #define GFP_VMALLOC32 GFP_KERNEL
> #endif
> 
> Which seems to be incorrect, it should always -or- in the DMA flags
> on top of GFP_KERNEL, thus this patch.
> 
> Signed-off-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> ---
> 
> This fixes frequent errors launchin X with the nouveau DRM for example.
> 
> Index: linux-work/mm/vmalloc.c
> ===================================================================
> --- linux-work.orig/mm/vmalloc.c	2007-07-18 16:22:00.000000000 +1000
> +++ linux-work/mm/vmalloc.c	2007-07-18 16:22:11.000000000 +1000
> @@ -578,9 +578,9 @@ void *vmalloc_exec(unsigned long size)
>  }
>  
>  #if defined(CONFIG_64BIT) && defined(CONFIG_ZONE_DMA32)
> -#define GFP_VMALLOC32 GFP_DMA32
> +#define GFP_VMALLOC32 GFP_DMA32 | GFP_KERNEL
>  #elif defined(CONFIG_64BIT) && defined(CONFIG_ZONE_DMA)
> -#define GFP_VMALLOC32 GFP_DMA
> +#define GFP_VMALLOC32 GFP_DMA | GFP_KERNEL
>  #else
>  #define GFP_VMALLOC32 GFP_KERNEL
>  #endif
> 

whoops, yes.

Are those errors serious and common enough for 2.6.22.x?  
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/