linux-kernel - Re: [PATCH 1/1][RESEND] Driver for the Atmel on-chip SSC on AT32AP and AT91.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1184833759.15007.33.camel@fuzzie.sanpeople.com>
Date:	19 Jul 2007 10:29:19 +0200
From:	Andrew Victor <andrew@...people.com>
To:	Hans-Christian Egtvedt <hcegtvedt@...el.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	kernel-avr32 <kernel@...32linux.org>,
	David Brownell <david-b@...bell.net>,
	Patrice Vilchez <patrice.vilchez@....atmel.com>,
	Nicolas Ferre <nicolas.ferre@....atmel.com>,
	Hans-Christian Egtvedt <egtvedt@...fundet.no>
Subject: Re: [PATCH 1/1][RESEND] Driver for the Atmel on-chip SSC on AT32AP
	and AT91.

hi Hans-Christian,

> This driver is used in the ALSA sound driver for the AT73C213 external DAC on
> the ATSTK1000 development board for AVR32. This sound driver will be submitted
> soon.

Seems to be more of an SCC unit allocation library, but OK.

I've also forwarded a copy of the patch to Frank Mandarino
<fmandarino@...relia.com> for his comments.  He maintains the current
AT91 SSC & ALSA support.  <sound/soc/at91/>


> +/* SSC Receive Clock Mode Register */
> +#define SSC_RCMR			0x00000010
> +#define SSC_RCMR_CKG_SIZE			 2
> +#define SSC_RCMR_CKG_OFFSET			 6
> +#define SSC_RCMR_CKI_SIZE			 1
> +#define SSC_RCMR_CKI_OFFSET			 5
> +#define SSC_RCMR_CKO_SIZE			 3

I'm personally not a fan of the register & bit definition format the
AVR32 driver seem to use.
Can we not rather move the existing include/asm-arm/arch-at91/at91_ssc.h
to somewhere shared as atmel_ssc.h ?


Regards,
  Andrew Victor


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/