linux-kernel - Re: [PATCH for review] [11/48] x86_64: During VM oom condition, kill all threads in process group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070719140411.GD16279@infradead.org>
Date:	Thu, 19 Jul 2007 15:04:11 +0100
From:	Christoph Hellwig <hch@...radead.org>
To:	Andi Kleen <ak@...e.de>
Cc:	will_schmidt@...t.ibm.com, linux-kernel@...r.kernel.org,
	linux-arch@...r.kernel.org
Subject: Re: [PATCH for review] [11/48] x86_64: During VM oom condition, kill all threads in process group

On Thu, Jul 19, 2007 at 03:48:40PM +0200, Andi Kleen wrote:
> 
> From: Will Schmidt <will_schmidt@...t.ibm.com>
> 
> During a VM oom condition, kill all threads in the process group.
> 
> We have had complaints where a threaded application is left in a bad state
> after one of it's threads is killed when we hit a VM: out_of_memory condition.
> 
> Killing just one of the process threads can leave the application in a bad
> state, whereas killing the entire process group would allow for the
> application to restart, or otherwise handled, and makes it very obvious that
> something has gone wrong.
> 
> This change allows the entire process group to be taken down, rather than just
> the one thread.

Shouldn't we have one patc hthat does this for every architecture instead
of going through arch maintainers and probably losing half of them?

> Index: linux/arch/x86_64/mm/fault.c
> ===================================================================
> --- linux.orig/arch/x86_64/mm/fault.c
> +++ linux/arch/x86_64/mm/fault.c
> @@ -569,7 +569,7 @@ out_of_memory:
>  	}
>  	printk("VM: killing process %s\n", tsk->comm);
>  	if (error_code & 4)
> -		do_exit(SIGKILL);
> +		do_group_exit(SIGKILL);
>  	goto no_context;
>  
>  do_sigbus:
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/