linux-kernel - Re: [PATCH][IPMI] Fix mem leak in try_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <20070719141830.GA4757@minyard.local>
Date:	Thu, 19 Jul 2007 09:18:30 -0500
From:	Corey Minyard <minyard@....org>
To:	Jesper Juhl <jesper.juhl@...il.com>, Andrew Morton <akpm@...l.org>
Cc:	Corey Minyard <minyard@...sta.com>,
	Christian Krafft <krafft@...ibm.com>,
	openipmi-developer@...ts.sourceforge.net,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][IPMI] Fix mem leak in try_init_dmi() code

Indeed this is a problem, please merge.  This is only called at init
time and only happens if the BIOS screws something up, so the leak is
slight and it is probably not worth sending to 2.6.22.x.  The driver
would not initialize the interface in the case, and I have no reports
of this happening.  I have booted and run tests on a system with this
patch.  Note that the original patch was munged by the mailer, here's
a new one.

If we ever hit the "default:" case in the switch in try_init_dmi(), 
then we'll leak the storage allocated with kzalloc() and assigned 
to 'info'. 

Signed-off-by: Jesper Juhl <jesper.juhl@...il.com>
Signed-off-by: Corey Minyard <cminyard@...sta.com>
---

 drivers/char/ipmi/ipmi_si_intf.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/char/ipmi/ipmi_si_intf.c 
b/drivers/char/ipmi/ipmi_si_intf.c
index 4edfdda..96d2f9e 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -2050,6 +2050,7 @@ static __devinit void try_init_dmi(struct dmi_ipmi_data *ipmi_data)
 		info->si_type = SI_BT;
 		break;
 	default:
+		kfree(info);
 		return;
 	}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/