linux-kernel - Re: [patch] fix the softlockup watchdog to actually work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070719145058.GA11971@elte.hu>
Date:	Thu, 19 Jul 2007 16:50:58 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	stable@...nel.org, Greg KH <greg@...ah.com>,
	Chris Wright <chrisw@...s-sol.org>
Subject: Re: [patch] fix the softlockup watchdog to actually work


* Jeremy Fitzhardinge <jeremy@...p.org> wrote:

> Hm, or more specifically, why would that be a problem for softlockup? 
> Do you mean it doesn't measure time during ACPI idle?  That would just 
> make it trigger later than it would otherwise.

no, the return value after idling can be completely random on some 
boxes, on a 64-bit scale - triggering the softlockup watchdog randomly. 
(some boxes return random TSC values, etc.) Again, it's fine for the 
scheduler's purpose, that's why i named it sched_clock().

the proper clocksource use within the kernel is ktime_get() [or 
ktime_get_ts()]. Do not abuse sched_clock() for such things.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/