[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1184866316.6458.31.camel@dhcp193.mvista.com>
Date: Thu, 19 Jul 2007 10:31:56 -0700
From: Daniel Walker <dwalker@...sta.com>
To: Andi Kleen <ak@...e.de>
Cc: patches@...-64.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [15/58] i386: Rewrite sched_clock
On Thu, 2007-07-19 at 19:22 +0200, Andi Kleen wrote:
> On Thursday 19 July 2007 19:15:38 Daniel Walker wrote:
> > On Thu, 2007-07-19 at 19:13 +0200, Andi Kleen wrote:
> > > > What about using the cycles2ns() clocksource helpers, it would eliminate
> > > > the duplication of the shift/multiply math .
> > >
> > > They are completely different from what clocksource provides.
> >
> > How so?
>
> The new sched_clock's works CPU local and relative to the last sync point.
>
Right, I guess I'm speaking more low-level than that .. Both function do
shift-multiply style math .. So between the two the cycles to
nanoseconds conversion code is duplicated, and the code to calculate the
multiply value is duplicated ..
>>From my perspective a downside to sched_clock is that the math is
duplicated per architecture .. I think it would be a win to use the
generic functions if it's possible..
Daniel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists