[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <469FA5E5.3070301@gmail.com>
Date: Thu, 19 Jul 2007 19:56:53 +0200
From: Rene Herman <rene.herman@...il.com>
To: Andrew Morton <akpm@...ux-foundation.org>
CC: Geert Uytterhoeven <Geert.Uytterhoeven@...ycom.com>,
Paul Mackerras <paulus@...ba.org>,
Jens Axboe <axboe@...nel.dk>,
"James E.J. Bottomley" <James.Bottomley@...elEye.com>,
Linux/PPC Development <linuxppc-dev@...abs.org>,
Linux Kernel Development <linux-kernel@...r.kernel.org>,
linux-scsi@...r.kernel.org,
Geoff Levand <geoffrey.levand@...sony.com>
Subject: Re: [patch 2/3] ps3: BD/DVD/CD-ROM Storage Driver
On 07/19/2007 11:47 AM, Andrew Morton wrote:
> On Thu, 19 Jul 2007 11:39:32 +0200 (CEST) Geert Uytterhoeven <Geert.Uytterhoeven@...ycom.com> wrote:
>
>>> Oh dear.
>>>
>>> ps3rom_priv(dev) = host;
>>>
>>> that's 'orrid. We have an identifier pretending to be a function, only we
>>> go and treat it as an lvalue.
>>>
>>> I mean, C code should look like C code, and the above just doesn't.
>>>
>>> Sigh.
You could insist that it be PS3ROM_PRIV() because then it at least also
_looks_ like cpp...
Rene.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists