linux-kernel - Re: kmalloc zero size changes break i386

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <469FB583.7070502@cs.helsinki.fi>
Date:	Thu, 19 Jul 2007 22:03:31 +0300
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
CC:	Roland Dreier <rdreier@...co.com>, Andi Kleen <ak@...e.de>,
	Christoph Lameter <clameter@....com>,
	linux-kernel@...r.kernel.org,
	"Michael S. Tsirkin" <mst@....mellanox.co.il>
Subject: Re: kmalloc zero size changes break i386

Linus Torvalds wrote:
> Ok, I think I see it: I think the mm/slab.c conversion of kmalloc(0) is
> totally broken.
> 
> The problem? It returns ZERO_SIZE_PTR from __find_general_cachep(), not 
> from __kmalloc(). So anythign that uses __find_general_cachep() will get 
> an invalid cachep pointer, which was not the point.
 >
 > Does something like this fix it?

I wondered about that too but I didn't spot any callers that would 
actually break. Andi? Roland?

> Christoph, please go over this and see if there are other cases like that.

__do_kmalloc_node probably.


				Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/