linux-kernel - Re: [PATCH 3/3] UIO: Hilscher CIF card driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200707192224.09062.hjk@linutronix.de>
Date:	Thu, 19 Jul 2007 22:24:09 +0200
From:	Hans-Jürgen Koch <hjk@...utronix.de>
To:	Jan Engelhardt <jengelh@...putergmbh.de>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] UIO: Hilscher CIF card driver

Am Donnerstag 19 Juli 2007 22:02 schrieb Jan Engelhardt:
> 
> On Jul 19 2007 21:28, Hans-Jürgen Koch wrote:
> >Am Donnerstag 19 Juli 2007 18:33 schrieb Jan Engelhardt:
> >> On Jul 18 2007 16:26, Greg Kroah-Hartman wrote:
> >> >
> >> >http://www.tglx.de/private/hjk/cif-orig-2.6.tar.bz2
> >> >
> >> >WARNING: Don't look at the code for too long, you might become sick :-)
> >> 
> >> Taking precautions for people? I get a 404...
> >
> >Now it's there.
> 
> aaaa, my eyes... ("Microsoft" is a good summary of the codingstyle...)

It's not just coding style, it's also concept. This was written with
the only goal to get a card working at one particular time. What happens
in future is not important. Would you like to port this driver to 2.6.22?
Would you like to post it on lkml, signed-off by you?

The concept is bad because the authors of that driver never tried to
find out how a driver should look like and what has to be done to get
it into mainline. Allright, with such a big driver for a relatively
unknown card(?) it's not easy to include that in mainline. That's
why we now have UIO... It greatly simplifies tasks like that.

I really hope that UIO will soon be used for industrial cards like
this one, and that we can fill drivers/uio/ with lots of small
kernel modules. And yes, these programmers in industry who wrote
drivers like the above, they will still be doing what they want and
what they're able to. But, hopefully, they'll now do it in userspace.

Thanks,
Hans

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/