linux-kernel - Re: [PATCH] procfs fixes for inotify/dnotify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070720045216.GA5831@martell.zuzino.mipt.ru>
Date:	Fri, 20 Jul 2007 08:52:16 +0400
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Thomas Ogrisegg <tom-lkml@...l.fnord.at>,
	linux-kernel@...r.kernel.org, rml@...ell.com,
	John McCutchan <ttb@...tacle.dhs.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>, robin.ksj@...il.com
Subject: Re: [PATCH] procfs fixes for inotify/dnotify

On Thu, Jul 19, 2007 at 03:03:55PM -0700, Andrew Morton wrote:
> 	http://bugzilla.kernel.org/show_bug.cgi?id=8782

[fsnotify and /proc]

> > --- linux-2.6.15/fs/proc/base.c
> > +++ linux-2.6.15.4/fs/proc/base.c
> > @@ -1945,6 +1945,7 @@
> >  	if(proc_dentry != NULL) {
> >  		shrink_dcache_parent(proc_dentry);
> >  		dput(proc_dentry);
> > +		fsnotify_nameremove (proc_dentry, 1);
> >  	}
> 
> I wonder if this is racy - after the dput() we might no longer have a
> reference?

It is indeed racy. dput() => kill_it: => d_kill() => d_free() =>
__d_free() eventually. *boom*

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/