linux-kernel - Re: [PATCH] Move KVM, paravirt, lguest, VMI and Xen under arch-level Virtualization option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1184911347.10380.274.camel@localhost.localdomain>
Date:	Fri, 20 Jul 2007 16:02:27 +1000
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Avi Kivity <avi@...ranet.com>
Cc:	lkml - Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andi Kleen <ak@....de>, Jeremy Fitzhardinge <jeremy@...p.org>,
	Zachary Amsden <zach@...are.com>,
	virtualization <virtualization@...ts.linux-foundation.org>
Subject: Re: [PATCH] Move KVM, paravirt, lguest, VMI and Xen under
	arch-level Virtualization option

On Fri, 2007-07-20 at 08:24 +0300, Avi Kivity wrote:
> Rusty Russell wrote:
> > Any objections?
> >
> > Rusty.
> > ===
> > Having KVM appear in the middle of "drivers" is kinda strange, and
> > having it alone under a menu called "virtualization" doubly so.
> >
> > 1) Move the "Virtualization" menu into the arch-specific i386 and
> >    x86-64 Kconfig.
> >   
> 
> Virtualization is hardly x86 specific.  How about moving it to
> top-level, and having individual items disable themselves on archs they
> don't apply to?
> 
> Otherwise we end up with $NARCH copies of that Kconfig, each slightly
> different.  The top-level entry can be made to depend on the archs that
> actually have some virt capability, so as not to show empty an menu.

I dislike the duplication, too, but 

1) it's a CPU capability, and that's where it belongs in the menu.
2) And as you can see from the difference between the x86_64 and i386
help text, there are real platform differences (and not mentioning
what's under the menu would be kinda cheating).
3) Virtualization doesn't even make sense as an option for some
platforms where it's always on.

Cheers,
Rusty.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/