[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20070720094547.GA664@elte.hu>
Date: Fri, 20 Jul 2007 11:45:47 +0200
From: Ingo Molnar <mingo@...e.hu>
To: Olaf Kirch <olaf.kirch@...cle.com>
Cc: "Kok, Auke" <auke-jan.h.kok@...el.com>,
Jarek Poplawski <jarkao2@...pl>,
Linus Torvalds <torvalds@...ux-foundation.org>,
linux-kernel@...r.kernel.org, davem@...emloft.net
Subject: Re: [patch] revert: [NET]: Fix races in net_rx_action vs netpoll
* Olaf Kirch <olaf.kirch@...cle.com> wrote:
> On Thursday 19 July 2007 21:56, Ingo Molnar wrote:
> > nope - with this patch applied the box still has no network, symptoms
> > are similar. (should i apply the WARN_ON() patch too?)
>
> Yes, that would be nice. If that doesn't help, you can also throw in
> the one below.
> - np->dev = ndev;
> if (!ndev->npinfo) {
> npinfo = kmalloc(sizeof(*npinfo), GFP_KERNEL);
> if (!npinfo) {
> @@ -722,6 +721,8 @@ int netpoll_setup(struct netpoll *np)
> }
> }
>
> + np->dev = ndev;
no change in behavior from this patch. If i add the WARN_ON() it
triggers once and it makes the network work as well (probably due to the
side-effect of the packets generated by the WARN_ON() printks).
Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists